Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zksolc v1.5.7 support #35

Merged
merged 2 commits into from
Nov 1, 2024
Merged

feat: zksolc v1.5.7 support #35

merged 2 commits into from
Nov 1, 2024

Conversation

Karrq
Copy link

@Karrq Karrq commented Nov 1, 2024

Add codegen and always serialize output selections

@Karrq Karrq requested a review from elfedy November 1, 2024 16:22
@Karrq Karrq changed the title feat: zksolc v.1.5.7 support feat: zksolc v1.5.7 support Nov 1, 2024
@elfedy
Copy link

elfedy commented Nov 1, 2024

@Karrq can you bump this version so that 1.5.7 is used in the tests?

Copy link
Collaborator

@hedgar2017 hedgar2017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Karrq Karrq merged commit 7d2dc97 into zksync-v0.11.4 Nov 1, 2024
4 checks passed
@Karrq Karrq deleted the feat/zksolc-1.5.7 branch November 1, 2024 19:28
Karrq added a commit that referenced this pull request Nov 26, 2024
* feat: zksolc 1.5.7 support

* chore: update version constants
Karrq added a commit that referenced this pull request Nov 26, 2024
* feat: add zksolc support

* fix: codeowner change (#32,#34)

* feat: zksolc v1.5.7 support (#35)

* feat: zksolc 1.5.7 support

* chore: update version constants

* feat: Support error / warning suppression in zksolc (#33)

feat: add FromStr to ZkSolcWarnings and ZkSolcErrors (#37)

* fix: add back skip filter over avoid-contracts

* feat(zk): properly mark unlinked contract (#40,#41,#43,#44)

feat(zk): mark bytecode as unlinked
refactor(zk): get output from `eravm` object
feat: retain pre-1.5.7 zksolc compatibility
test(artifact:zk): unprefixed bytecode test

* chore: bump version

* chore: merge conflicts 11.6->12.3

feat(zk): per-source profile & settings
feat(zk): stub our zksolc settings restrictions

* fix(ci): update rust toolchain version

* fix(ci): proper rust toolchain name

* chore: clippy

---------

Co-authored-by: Federico Rodríguez <[email protected]>
Co-authored-by: Tomi Moreno <[email protected]>
Co-authored-by: Alex Ostrovski <[email protected]>
Co-authored-by: Dustin Brickwood <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants